pgsql: Remove special cases for ETXTBSY from new fsync'ing logic. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.
Date
Msg-id E1YyPhG-0004UW-2W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove special cases for ETXTBSY from new fsync'ing logic.

The argument that this is a sufficiently-expected case to be silently
ignored seems pretty thin.  Andres had brought it up back when we were
still considering that most fsync failures should be hard errors, and it
probably would be legit not to fail hard for ETXTBSY --- but the same is
true for EROFS and other cases, which is why we gave up on hard failures.
ETXTBSY is surely not a normal case, so logging the failure seems fine
from here.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/70a4519b82beee9e7bffb17ae4e6d81bb3ab89d8

Modified Files
--------------
src/backend/storage/file/fd.c |   15 +++------------
src/bin/initdb/initdb.c       |   12 ------------
2 files changed, 3 insertions(+), 24 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.