pgsql: Represent columns requiring insert and update privileges indente - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Represent columns requiring insert and update privileges indente
Date
Msg-id E1YqUEi-00047X-Uv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Represent columns requiring insert and update privileges indentently.

Previously, relation range table entries used a single Bitmapset field
representing which columns required either UPDATE or INSERT privileges,
despite the fact that INSERT and UPDATE privileges are separately
cataloged, and may be independently held.  As statements so far required
either insert or update privileges but never both, that was
sufficient. The required permission could be inferred from the top level
statement run.

The upcoming INSERT ... ON CONFLICT UPDATE feature needs to
independently check for both privileges in one statement though, so that
is not sufficient anymore.

Bumps catversion as stored rules change.

Author: Peter Geoghegan
Reviewed-By: Andres Freund

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2c8f4836db058d0715bc30a30655d646287ba509

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c       |    2 +-
contrib/sepgsql/dml.c                     |   31 +++++---
src/backend/commands/copy.c               |    2 +-
src/backend/commands/createas.c           |    2 +-
src/backend/commands/trigger.c            |   30 +++----
src/backend/executor/execMain.c           |  124 ++++++++++++++++++-----------
src/backend/nodes/copyfuncs.c             |    3 +-
src/backend/nodes/equalfuncs.c            |    3 +-
src/backend/nodes/outfuncs.c              |    3 +-
src/backend/nodes/readfuncs.c             |    3 +-
src/backend/optimizer/plan/setrefs.c      |    6 +-
src/backend/optimizer/prep/prepsecurity.c |    6 +-
src/backend/optimizer/prep/prepunion.c    |    8 +-
src/backend/parser/analyze.c              |    4 +-
src/backend/parser/parse_relation.c       |   21 +++--
src/backend/rewrite/rewriteHandler.c      |   52 +++++++-----
src/include/catalog/catversion.h          |    2 +-
src/include/nodes/parsenodes.h            |   14 ++--
18 files changed, 192 insertions(+), 124 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Improve BRIN infra, minmax opclass and regression test
Next
From: Tom Lane
Date:
Subject: Re: pgsql: hstore_plpython: Support tests on Python 2.3