pgsql: Fix unaligned memory access in xlog parsing due to replication o - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix unaligned memory access in xlog parsing due to replication o
Date
Msg-id E1Yo7f2-00036T-LT@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix unaligned memory access in xlog parsing due to replication origin patch.

ParseCommitRecord() accessed xl_xact_origin directly. But the chunks in
the commit record's data only have 4 byte alignment, whereas
xl_xact_origin's members require 8 byte alignment on some
platforms. Update comments to make not of that and copy the record to
stack local storage before reading.

With help from Stefan Kaltenbrunner in pinning down the buildfarm and
verifying the fix.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1db12da85bee7a01abfbbf2798904347e4d9515a

Modified Files
--------------
src/backend/access/rmgrdesc/xactdesc.c |    9 ++++++---
src/include/access/xact.h              |    5 +++--
2 files changed, 9 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix pg_rewind regression failure after "fast promotion"
Next
From: Andres Freund
Date:
Subject: pgsql: Copy editing of the replication origins patch.