pgsql: Improve pg_check_dir code and comments. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Improve pg_check_dir code and comments.
Date
Msg-id E1YNk8Q-0004Il-0h@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Improve pg_check_dir code and comments.
List pgsql-committers
Improve pg_check_dir code and comments.

Avoid losing errno if readdir() fails and closedir() works.  Consistently
return 4 rather than 3 if both a lost+found directory and other files are
found, rather than returning one value or the other depending on the
order of the directory listing.  Update comments to match the actual
behavior.

These oversights date to commits 6f03927fce038096f53ca67eeab9adb24938f8a6
and 17f15239325a88581bb4f9cf91d38005f1f52d69.

Marco Nenciarini

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5d6c2405f4bae6c87533d981d6a47587db501220

Modified Files
--------------
src/port/pgcheckdir.c |   23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix wrong merge resolution making pg_receivexlog fail in 9.2.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Improve pg_check_dir code and comments.