pgsql: Don't open a WAL segment for writing at end of recovery. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Don't open a WAL segment for writing at end of recovery.
Date
Msg-id E1Y8rTT-0000c1-N9@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't open a WAL segment for writing at end of recovery.

Since commit ba94518a, we used XLogFileOpen to open the next segment for
writing, but if the end-of-recovery happens exactly at a segment boundary,
the new segment might not exist yet. (Before ba94518a, XLogFileOpen was
correct, because we would open the previous segment if the switch happened
at the boundary.)

Instead of trying to create it if necessary, it's simpler to not bother
opening the segment at all. XLogWrite() will open or create it soon anyway,
after writing the checkpoint or end-of-recovery record.

Reported by Andres Freund.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1e78d81e883d7987de8da559d985958335820cc8

Modified Files
--------------
src/backend/access/transam/xlog.c |    5 -----
1 file changed, 5 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix namespace handling in xpath function
Next
From: Robert Haas
Date:
Subject: pgsql: docs: Reword CREATE POLICY documentation.