pgsql: Treat negative values of recovery_min_apply_delay as having no e - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Treat negative values of recovery_min_apply_delay as having no e
Date
Msg-id E1Y7TDQ-00056l-Vl@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Treat negative values of recovery_min_apply_delay as having no effect.

At one point in the development of this feature, it was claimed that
allowing negative values would be useful to compensate for timezone
differences between master and slave servers.  That was based on a mistaken
assumption that commit timestamps are recorded in local time; but of course
they're in UTC.  Nor is a negative apply delay likely to be a sane way of
coping with server clock skew.  However, the committed patch still treated
negative delays as doing something, and the timezone misapprehension
survived in the user documentation as well.

If recovery_min_apply_delay were a proper GUC we'd just set the minimum
allowed value to be zero; but for the moment it seems better to treat
negative settings as if they were zero.

In passing do some extra wordsmithing on the parameter's documentation,
including correcting a second misstatement that the parameter affects
processing of Restore Point records.

Issue noted by Michael Paquier, who also provided the code patch; doc
changes by me.  Back-patch to 9.4 where the feature was introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d6657d2a107bee20d63ec2f776d873242f9355e9

Modified Files
--------------
doc/src/sgml/recovery-config.sgml |   23 +++++++++++------------
src/backend/access/transam/xlog.c |    2 +-
2 files changed, 12 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Treat negative values of recovery_min_apply_delay as having no e
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Change how first WAL segment on new timeline after promotion is