pgsql: Fix failure of contrib/auto_explain to print per-node timing inf - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix failure of contrib/auto_explain to print per-node timing inf
Date
Msg-id E1XV1qK-0005F5-Um@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix failure of contrib/auto_explain to print per-node timing information.

This has been broken since commit af7914c6627bcf0b0ca614e9ce95d3f8056602bf,
which added the EXPLAIN (TIMING) option.  Although that commit included
updates to auto_explain, they evidently weren't tested very carefully,
because the code failed to print node timings even when it should, due to
failure to set es.timing in the ExplainState struct.  Reported off-list by
Neelakanth Nadgir of Salesforce.

In passing, clean up the documentation for auto_explain's options a
little bit, including re-ordering them into what seems to me a more
logical order.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/47288bd08c0169ecb5eb50742336cc0df813777e

Modified Files
--------------
contrib/auto_explain/auto_explain.c |    5 +--
doc/src/sgml/auto-explain.sgml      |   77 ++++++++++++++++++++---------------
2 files changed, 46 insertions(+), 36 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix failure of contrib/auto_explain to print per-node timing inf
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Allow units to be specified in relation option setting value.