Fix decoding of MULTI_INSERTs when rows other than the last are toasted.
When decoding the results of a HEAP2_MULTI_INSERT (currently only
generated by COPY FROM) toast columns for all but the last tuple
weren't replaced by their actual contents before being handed to the
output plugin. The reassembled toast datums where disregarded after
every REORDER_BUFFER_CHANGE_(INSERT|UPDATE|DELETE) which is correct
for plain inserts, updates, deletes, but not multi inserts - there we
generate several REORDER_BUFFER_CHANGE_INSERTs for a single
xl_heap_multi_insert record.
To solve the problem add a clear_toast_afterwards boolean to
ReorderBufferChange's union member that's used by modifications. All
row changes but multi_inserts always set that to true, but
multi_insert sets it only for the last change generated.
Add a regression test covering decoding of multi_inserts - there was
none at all before.
Backpatch to 9.4 where logical decoding was introduced.
Bug found by Petr Jelinek.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/d54712e7cf2e8925d1e04782a0aec88eae2be72c
Modified Files
--------------
contrib/test_decoding/expected/toast.out | 20 +++++++++++++++++++-
contrib/test_decoding/sql/toast.sql | 13 +++++++++++++
src/backend/replication/logical/decode.c | 10 ++++++++++
src/backend/replication/logical/reorderbuffer.c | 9 ++++++++-
src/include/replication/reorderbuffer.h | 4 ++++
5 files changed, 54 insertions(+), 2 deletions(-)
