pgsql: Consistently pass an "unsigned char" to ctype.h functions. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Consistently pass an "unsigned char" to ctype.h functions.
Date
Msg-id E1X3eEO-0008Os-9B@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Consistently pass an "unsigned char" to ctype.h functions.

The isxdigit() calls relied on undefined behavior.  The isascii() call
was well-defined, but our prevailing style is to include the cast.
Back-patch to 9.4, where the isxdigit() calls were introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/333b7db8b39679acf0665b3fc4ad99cbc14fbba7

Modified Files
--------------
contrib/pg_upgrade/controldata.c |    2 +-
src/backend/utils/adt/json.c     |    7 +++++--
2 files changed, 6 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Kevin Grittner
Date:
Subject: pgsql: Remove dead typeStruct variable from plpy_spi.c.
Next
From: Noah Misch
Date:
Subject: pgsql: Consistently pass an "unsigned char" to ctype.h functions.