pgsql: Check interrupts during logical decoding more frequently. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Check interrupts during logical decoding more frequently.
Date
Msg-id E1X1YTe-0002x0-Je@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Check interrupts during logical decoding more frequently.

When reading large amounts of preexisting WAL during logical decoding
using the SQL interface we possibly could fail to check interrupts in
due time. Similarly the same could happen on systems with a very high
WAL volume while creating a new logical replication slot, independent
of the used interface.

Previously these checks where only performed in xlogreader's read_page
callbacks, while waiting for new WAL to be produced. That's not
sufficient though, if there's never a need to wait.  Walsender's send
loop already contains a interrupt check.

Backpatch to 9.4 where the logical decoding feature was introduced.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6ad903d70a440eb0fbe0b33ceb87a8b0a81cb240

Modified Files
--------------
src/backend/replication/logical/logical.c      |    7 ++-----
src/backend/replication/logical/logicalfuncs.c |    1 +
2 files changed, 3 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Check interrupts during logical decoding more frequently.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Check interrupts during logical decoding more frequently.