pgsql: Don't allow foreign tables with OIDs. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Don't allow foreign tables with OIDs.
Date
Msg-id E1WzO1t-0004KR-1j@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't allow foreign tables with OIDs.

The syntax doesn't let you specify "WITH OIDS" for foreign tables, but it
was still possible with default_with_oids=true. But the rest of the system,
including pg_dump, isn't prepared to handle foreign tables with OIDs
properly.

Backpatch down to 9.1, where foreign tables were introduced. It's possible
that there are databases out there that already have foreign tables with
OIDs. There isn't much we can do about that, but at least we can prevent
them from being created in the future.

Patch by Etsuro Fujita, reviewed by Hadi Moshayedi.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a87a7dc8b64a99e5e497591dddb37b3ecdfae2eb

Modified Files
--------------
src/backend/commands/tablecmds.c |    3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Check for interrupts during tuple-insertion loops.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Don't allow foreign tables with OIDs.