pgsql: Set the process latch when processing recovery conflict interrup - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Set the process latch when processing recovery conflict interrup
Date
Msg-id E1WrnrR-0002RZ-Kz@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Set the process latch when processing recovery conflict interrupts.

Because RecoveryConflictInterrupt() didn't set the process latch
anything using the latter to wait for events didn't get notified about
recovery conflicts. Most latch users are never the target of recovery
conflicts, which explains the lack of reports about this until
now.
Since 9.3 two possible affected users exist though: The sql callable
pg_sleep() now uses latches to wait and background workers are
expected to use latches in their main loop. Both would currently wait
until the end of WaitLatch's timeout.

Fix by adding a SetLatch() to RecoveryConflictInterrupt(). It'd also
be possible to fix the issue by having each latch user set
set_latch_on_sigusr1. That seems failure prone and though, as most of
these callsites won't often receive recovery conflicts and thus will
likely only be tested against normal query cancels et al. It'd also be
unnecessarily verbose.

Backpatch to 9.1 where latches were introduced. Arguably 9.3 would be
sufficient, because that's where pg_sleep() was converted to waiting
on the latch and background workers got introduced; but there could be
user level code making use of the latch pre 9.3.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/05d22d06ae0ffa63e4e4885ae8db23ca827c1825

Modified Files
--------------
src/backend/tcop/postgres.c |   10 ++++++++++
1 file changed, 10 insertions(+)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Set the process latch when processing recovery conflict interrup
Next
From: Tom Lane
Date:
Subject: pgsql: Make plpython_unicode regression test work in more database enco