pgsql: Fix uuid-ossp regression tests based on buildfarm feedback. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix uuid-ossp regression tests based on buildfarm feedback.
Date
Msg-id E1Wpqou-0002x8-2X@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix uuid-ossp regression tests based on buildfarm feedback.

The previous version of these tests expected uuid_generate_v1() to always
emit MAC addresses with the local-admin and multicast address bits zero.
However, several of the buildfarm critters are reporting values with the
local-admin bit set.  (Perhaps they're running inside VMs or jails.)
And a couple are reporting values with the multicast bit set, probably
meaning that the UUID library couldn't read the system MAC address.

Also, it emerges that if OSSP UUID can't read the system MAC address, it
falls back to V1MC behavior wherein the whole node field gets randomized
each time, breaking the test that expected the node field to remain stable
in V1 output.  (It looks like e2fs doesn't behave that way, though.)

It's not entirely clear why we can't get a system MAC address, since the
buildfarm scripts would not work without internet access.  Nonetheless,
the regression tests had better cope with the case, so adjust the tests
to expect these behaviors.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/25dd07e0f6ba1aef0a6802474112b5bcce621ea4

Modified Files
--------------
contrib/uuid-ossp/expected/uuid_ossp.out |   46 ++++++++++++++++++++----------
contrib/uuid-ossp/sql/uuid_ossp.sql      |   32 ++++++++++++++++-----
2 files changed, 56 insertions(+), 22 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Revert "Fix bogus %name-prefix option syntax in all our Bison fi
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.