pgsql: Code review for logical decoding patch. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Code review for logical decoding patch.
Date
Msg-id E1Wim61-0008S4-6r@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Code review for logical decoding patch.

Post-commit review identified a number of places where addition was
used instead of multiplication or memory wasn't zeroed where it should
have been.  This commit also fixes one case where a structure member
was mis-initialized, and moves another memory allocation closer to
the place where the allocated storage is used for clarity.

Andres Freund

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f1d8dd3647fd0c87f0fb238f7cfc45c1ce282a55

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c |   13 +++++--------
src/backend/replication/logical/snapbuild.c     |   11 +++++------
2 files changed, 10 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Remove overeager assertion in logical_heap_begin_rewrite.
Next
From: Tom Lane
Date:
Subject: pgsql: Get rid of bogus dependency on typcategory in to_json() and frie