pgsql: isdigit() needs an unsigned char argument. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: isdigit() needs an unsigned char argument.
Date
Msg-id E1WLeAX-0002ji-VL@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
isdigit() needs an unsigned char argument.

Per the C standard, the routine should be passed an int, with a value that's
representable as an unsigned char or EOF. Passing a signed char is wrong,
because a negative value is not representable as an unsigned char.
Unfortunately no compiler warns about that.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a0c2fa9b5cfaf9595e8809a68eec929a5052834e

Modified Files
--------------
src/backend/utils/adt/timestamp.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Don't reject ROW_MARK_REFERENCE rowmarks for materialized views.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Send keepalives from walsender even when busy sending WAL.