pgsql: Fix length checking for Unicode identifiers containing escapes ( - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix length checking for Unicode identifiers containing escapes (
Date
Msg-id E1WE1uZ-0001IL-Ip@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix length checking for Unicode identifiers containing escapes (U&"...").

We used the length of the input string, not the de-escaped string, as
the trigger for NAMEDATALEN truncation.  AFAICS this would only result
in sometimes printing a phony truncation warning; but it's just luck
that there was no worse problem, since we were violating the API spec
for truncate_identifier().  Per bug #9204 from Joshua Yanovski.

This has been wrong since the Unicode-identifier support was added,
so back-patch to all supported branches.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ca1c171817c5518932ce549d138f028f5d4d9398

Modified Files
--------------
src/backend/parser/scan.l |   16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: pg_upgrade: mention the need for tablespace snapshots in docs
Next
From: Tom Lane
Date:
Subject: pgsql: Fix length checking for Unicode identifiers containing escapes (