pgsql: Accept pg_upgraded tuples during multixact freezing - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Accept pg_upgraded tuples during multixact freezing
Date
Msg-id E1W1jK1-0000e5-Ve@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Accept pg_upgraded tuples during multixact freezing

The new MultiXact freezing routines introduced by commit 8e9a16ab8f7
neglected to consider tuples that came from a pg_upgrade'd database; a
vacuum run that tried to freeze such tuples would die with an error such
as
ERROR: MultiXactId 11415437 does no longer exist -- apparent wraparound

To fix, ensure that GetMultiXactIdMembers is allowed to return empty
multis when the infomask bits are right, as is done in other callsites.

Per trouble report from F-Secure.

In passing, fix a copy&paste bug reported by Andrey Karpov from VIVA64
from their PVS-Studio static checked, that instead of setting relminmxid
to Invalid, we were setting relfrozenxid twice.  Not an important
mistake because that code branch is about relations for which we don't
use the frozenxid/minmxid values at all in the first place, but seems to
warrants a fix nonetheless.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/a25c2b7c4db3b4542e05d660e55bef5c93fdc32d

Modified Files
--------------
src/backend/access/heap/heapam.c |   10 ++++++++--
src/backend/catalog/heap.c       |    2 +-
2 files changed, 9 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Accept pg_upgraded tuples during multixact freezing
Next
From: Bruce Momjian
Date:
Subject: pgsql: Move username lookup functions from /port to /common