pgsql: Fix pause_at_recovery_target + recovery_target_inclusive combina - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix pause_at_recovery_target + recovery_target_inclusive combina
Date
Msg-id E1W10kN-0007Sw-BK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix pause_at_recovery_target + recovery_target_inclusive combination.

If pause_at_recovery_target is set, recovery pauses *before* applying the
target record, even if recovery_target_inclusive is set. If you then
continue with pg_xlog_replay_resume(), it will apply the target record
before ending recovery. In other words, if you log in while it's paused
and verify that the database looks OK, ending recovery changes its state
again, possibly destroying data that you were tring to salvage with PITR.

Backpatch to 9.1, this has been broken since pause_at_recovery_target was
added.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3739e5ab93afb21b69da2e42f6e161ef63aa95c8

Modified Files
--------------
src/backend/access/transam/xlog.c |   11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Avoid extra AggCheckCallContext() checks in ordered-set aggregat
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix pause_at_recovery_target + recovery_target_inclusive combina