pgsql: Clear retry flags properly in replacement OpenSSL sock_write fun - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Clear retry flags properly in replacement OpenSSL sock_write fun
Date
Msg-id E1Vod33-00006f-2F@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Clear retry flags properly in replacement OpenSSL sock_write function.

Current OpenSSL code includes a BIO_clear_retry_flags() step in the
sock_write() function.  Either we failed to copy the code correctly, or
they added this since we copied it.  In any case, lack of the clear step
appears to be the cause of the server lockup after connection loss reported
in bug #8647 from Valentine Gogichashvili.  Assume that this is correct
coding for all OpenSSL versions, and hence back-patch to all supported
branches.

Diagnosis and patch by Alexander Kukushkin.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/41042970be02778c9fef4b3f7ed0c5c07adc8cc6

Modified Files
--------------
src/backend/libpq/be-secure.c |    6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update
Next
From: Tom Lane
Date:
Subject: pgsql: Clear retry flags properly in replacement OpenSSL sock_write fun