pgsql: Work around NetBSD shell issue in pg_upgrade test script. - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Work around NetBSD shell issue in pg_upgrade test script.
Date
Msg-id E1VapBC-0003zk-Uq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Work around NetBSD shell issue in pg_upgrade test script.

The NetBSD shell apparently returns non-zero from an unset command if
the variable is already unset. This matters when, as in pg_upgrade's
test.sh, we are working under 'set -e'. To protect against this, we
first set the PG variables to an empty string before unsetting them
completely.

Error found on buildfarm member coypu, solution from Rémi Zara.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9060cb96805e0d3cfe74c0919feb5e2ce1034ffc

Modified Files
--------------
contrib/pg_upgrade/test.sh |   22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Work around NetBSD shell issue in pg_upgrade test script.
Next
From: Robert Haas
Date:
Subject: pgsql: Modify dynamic shared memory code to use Size rather than uint64