pgsql: Fix removal of files in pgstats directories - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix removal of files in pgstats directories
Date
Msg-id E1VBXQn-0006lq-V0@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix removal of files in pgstats directories

Instead of deleting all files in stats_temp_directory and the permanent
directory on a crash, only remove those files that match the pattern of
files we actually write in them, to avoid possibly clobbering existing
unrelated contents of the temporary directory.  Per complaint from Jeff
Janes, and subsequent discussion, starting at message
CAMkU=1z9+7RsDODnT4=cDFBRBp8wYQbd_qsLcMtKEf-oFwuOdQ@mail.gmail.com

Also, fix a bug in the same routine to avoid removing files from the
permanent directory twice (instead of once from that directory and then
from the temporary directory), also per report from Jeff Janes, in
message
CAMkU=1wbk947=-pAosDMX5VC+sQw9W4ttq6RM9rXu=MjNeEQKA@mail.gmail.com

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/db5b49cdd4f481828b227f03b373fbc9bde4301a

Modified Files
--------------
src/backend/postmaster/pgstat.c |   33 ++++++++++++++++++++++++++++-----
1 file changed, 28 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix removal of files in pgstats directories
Next
From: Tom Lane
Date:
Subject: pgsql: Be more wary of unwanted whitespace in pgstat_reset_remove_files