pgsql: Fix end-of-loop optimization in pglz_find_match() function. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix end-of-loop optimization in pglz_find_match() function.
Date
Msg-id E1UzVfS-0007el-5R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix end-of-loop optimization in pglz_find_match() function.

After the recent pglz optimization patch, the next/prev pointers in the
hash table are never NULL, INVALID_ENTRY_PTR is used to represent invalid
entries instead. The end-of-loop check in pglz_find_match() function didn't
get the memo. The result was the same from a correctness point of view, but
because the NULL-check would never fail, the tiny optimization turned into
a pessimization.

Reported by Stephen Frost, using Coverity scanner.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3f2adace1ec025908b5189f0773b4eaab3d228d5

Modified Files
--------------
src/backend/utils/adt/pg_lzcompress.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Fix typo in previous pgbench --progress patch.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix assert failure at end of recovery, broken by XLogInsert scal