pgsql: Properly dump dropped foreign table cols in binary-upgrade mode. - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Properly dump dropped foreign table cols in binary-upgrade mode.
Date
Msg-id E1UrXLO-0004lH-DA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Properly dump dropped foreign table cols in binary-upgrade mode.

In binary upgrade mode, we need to recreate and then drop dropped
columns so that all the columns get the right attribute number. This is
true for foreign tables as well as for native tables. For foreign
tables we have been getting the first part right but not the second,
leading to bogus columns in the upgraded database. Fix this all the way
back to 9.1, where foreign tables were introduced.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/1c6afc40f7f9e3fd823e415adbfa6b2ac6f9864d

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |   12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Properly dump dropped foreign table cols in binary-upgrade mode.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Avoid inconsistent type declaration