pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral
Date
Msg-id E1UjZMW-0002kk-Qq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add semicolons to eval'd strings to hide a minor Perl behavioral change.

"eval q{foo}" used to complain that the error was on line 2 of the eval'd
string, because eval internally tacked on "\n;" so that the end of the
erroneous command was indeed on line 2.  But as of Perl 5.18 it more
sanely says that the error is on line 1.  To avoid Perl-version-dependent
regression test results, use "eval q{foo;}" instead in the two places
where this matters.  Per buildfarm.

Since people might try to use newer Perl versions with older PG releases,
back-patch as far as 9.0 where these test cases were added.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/cc510d97afe63cacb3129d4bd19b14118cada6bb

Modified Files
--------------
src/pl/plperl/expected/plperl.out      |    4 ++--
src/pl/plperl/expected/plperl_init.out |   10 +++++-----
src/pl/plperl/sql/plperl.sql           |    2 +-
src/pl/plperl/sql/plperl_init.sql      |    2 +-
4 files changed, 9 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Put back allow_system_table_mods check in heap_create().
Next
From: Tom Lane
Date:
Subject: pgsql: Add semicolons to eval'd strings to hide a minor Perl behavioral