pgsql: Remove PageSetTLI and rename pd_tli to pd_checksum - Mailing list pgsql-committers

From Simon Riggs
Subject pgsql: Remove PageSetTLI and rename pd_tli to pd_checksum
Date
Msg-id E1UHaST-0007bH-CC@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove PageSetTLI and rename pd_tli to pd_checksum
Remove use of PageSetTLI() from all page manipulation functions
and adjust README to indicate change in the way we make changes
to pages. Repurpose those bytes into the pd_checksum field and
explain how that works in comments about page header.

Refactoring ahead of actual feature patch which would make use
of the checksum field, arriving later.

Jeff Davis, with comments and doc changes by Simon Riggs
Direction suggested by Robert Haas; many others providing
review comments.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bb7cc2623f242ffafae404f8ebbb331b9a7f2b68

Modified Files
--------------
contrib/pageinspect/Makefile            |    3 ++-
contrib/pageinspect/pageinspect.control |    2 +-
contrib/pageinspect/rawpage.c           |    2 +-
doc/src/sgml/pageinspect.sgml           |    6 +++---
src/backend/access/gin/ginbtree.c       |    6 ------
src/backend/access/gin/ginfast.c        |    5 -----
src/backend/access/gin/gininsert.c      |    3 ---
src/backend/access/gin/ginutil.c        |    1 -
src/backend/access/gin/ginvacuum.c      |    4 ----
src/backend/access/gin/ginxlog.c        |   17 -----------------
src/backend/access/gist/gist.c          |    3 ---
src/backend/access/gist/gistbuild.c     |    1 -
src/backend/access/gist/gistvacuum.c    |    1 -
src/backend/access/gist/gistxlog.c      |    4 ----
src/backend/access/heap/heapam.c        |   25 ++-----------------------
src/backend/access/heap/pruneheap.c     |    1 -
src/backend/access/heap/visibilitymap.c |    1 -
src/backend/access/nbtree/nbtinsert.c   |    8 --------
src/backend/access/nbtree/nbtpage.c     |   17 ++++-------------
src/backend/access/nbtree/nbtsort.c     |    5 -----
src/backend/access/nbtree/nbtxlog.c     |   12 ------------
src/backend/access/spgist/spgdoinsert.c |   15 ---------------
src/backend/access/spgist/spginsert.c   |    3 ---
src/backend/access/spgist/spgvacuum.c   |    3 ---
src/backend/access/spgist/spgxlog.c     |   21 ---------------------
src/backend/access/transam/README       |    7 +++----
src/backend/access/transam/xlog.c       |    1 -
src/backend/commands/sequence.c         |    5 -----
src/backend/commands/vacuumlazy.c       |    2 --
src/include/storage/bufpage.h           |   27 ++++++++++++++-------------
30 files changed, 30 insertions(+), 181 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Increase timeout delays in new timeouts isolation test.
Next
From: Simon Riggs
Date:
Subject: pgsql: Add pageinspect--1.1.sql for checksum changes