pgsql: Improve error reporting in code that checks for buffer refcount - Mailing list pgsql-committers

Improve error reporting in code that checks for buffer refcount leaks.

Formerly we just Assert'ed that each refcount was zero, which was quick
and easy but failed to provide a good overview of what was wrong.
Change the code so that we'll call PrintBufferLeakWarning() for each
buffer with a nonzero refcount, and then Assert at the end of the loop.
This costs nothing in runtime and might ease diagnosis of some bugs.

Greg Smith, reviewed by Satoshi Nagayasu, further tweaked by me

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/dcafdbcde1baf256891be6af77868b84889b435d

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c   |   24 ++++++++++++++++++------
src/backend/storage/buffer/localbuf.c |   22 +++++++++++++++++++---
2 files changed, 37 insertions(+), 9 deletions(-)