pgsql: Introduce less-bogus handling of collations in contrib/postgres_ - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Introduce less-bogus handling of collations in contrib/postgres_
Date
Msg-id E1UFvNY-0005R8-Qz@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Introduce less-bogus handling of collations in contrib/postgres_fdw.

Treat expressions as being remotely executable only if all collations used
in them are determined by Vars of the foreign table.  This means that, if
the foreign server gets different answers than we do, it's the user's fault
for not having marked the foreign table columns with collations equivalent
to the remote table's.  This rule allows most simple expressions such as
"var < 'constant'" to be sent to the remote side, because the constant
isn't determining the collation (the Var's collation would win).  There's
still room for improvement, but it's hard to see how to do it without a
lot more knowledge and/or assumptions about what the remote side will do.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ed3ddf918b59545583a4b374566bc1148e75f593

Modified Files
--------------
contrib/postgres_fdw/deparse.c                 |  416 +++++++++++++++++++++---
contrib/postgres_fdw/expected/postgres_fdw.out |   95 +++++-
contrib/postgres_fdw/sql/postgres_fdw.sql      |   23 ++-
3 files changed, 474 insertions(+), 60 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: SP-GiST support of the range adjacent operator -|-
Next
From: Kevin Grittner
Date:
Subject: pgsql: Fix bug in dumping prior releases due to MV REFRESH dependency c