pgsql: Fix possible failure to send final transaction counts to stats c - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix possible failure to send final transaction counts to stats c
Date
Msg-id E1U3XOr-0000Oj-PQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix possible failure to send final transaction counts to stats collector.

Normally, we suppress sending a tabstats message to the collector unless
there were some actual table stats to send.  However, during backend exit
we should force out the message if there are any transaction commit/abort
counts to send, else the session's last few commit/abort counts will never
get reported at all.  We had logic for this, but the short-circuit test
at the top of pgstat_report_stat() ignored the "force" flag, with the
consequence that session-ending transactions that touched no database-local
tables would not get counted.  Seems to be an oversight in my commit
641912b4d17fd214a5e5bae4e7bb9ddbc28b144b, which added the "force" flag.
That was back in 8.3, so back-patch to all supported versions.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/1618b87eb1722c6331b47dd9a2cc801408b99b13

Modified Files
--------------
src/backend/postmaster/pgstat.c |    4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Simon Riggs
Date:
Subject: pgsql: Rely only on checkpoint 1 at end of recovery.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix possible failure to send final transaction counts to stats c