pgsql: Fix grammar for subscripting or field selection from a sub-SELEC - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix grammar for subscripting or field selection from a sub-SELEC
Date
Msg-id E1U0dAw-0003eD-FR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix grammar for subscripting or field selection from a sub-SELECT result.

Such cases should work, but the grammar failed to accept them because of
our ancient precedence hacks to convince bison that extra parentheses
around a sub-SELECT in an expression are unambiguous.  (Formally, they
*are* ambiguous, but we don't especially care whether they're treated as
part of the sub-SELECT or part of the expression.  Bison cares, though.)
Fix by adding a redundant-looking production for this case.

This is a fine example of why fixing shift/reduce conflicts via
precedence declarations is more dangerous than it looks: you can easily
cause the parser to reject cases that should work.

This has been wrong since commit 3db4056e22b0c6b2adc92543baf8408d2894fe91
or maybe before, and apparently some people have been working around it
by inserting no-op casts.  That method introduces a dump/reload hazard,
as illustrated in bug #7838 from Jan Mate.  Hence, back-patch to all
active branches.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/66e6916b936b57b4a6f6bf8a2bafcde4a2d36878

Modified Files
--------------
src/backend/parser/gram.y               |   22 ++++++++++++
src/test/regress/expected/subselect.out |   55 +++++++++++++++++++++++++++++++
src/test/regress/sql/subselect.sql      |   15 ++++++++
3 files changed, 92 insertions(+), 0 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix grammar for subscripting or field selection from a sub-SELEC
Next
From: Tom Lane
Date:
Subject: pgsql: Fix grammar for subscripting or field selection from a sub-SELEC