pgsql: Fix SPI documentation for new handling of ExecutorRun's count pa - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix SPI documentation for new handling of ExecutorRun's count pa
Date
Msg-id E1TyWJY-0007QX-Lq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix SPI documentation for new handling of ExecutorRun's count parameter.

Since 9.0, the count parameter has only limited the number of tuples
actually returned by the executor.  It doesn't affect the behavior of
INSERT/UPDATE/DELETE unless RETURNING is specified, because without
RETURNING, the ModifyTable plan node doesn't return control to execMain.c
for each tuple.  And we only check the limit at the top level.

While this behavioral change was unintentional at the time, discussion of
bug #6572 led us to the conclusion that we prefer the new behavior anyway,
and so we should just adjust the docs to match rather than change the code.
Accordingly, do that.  Back-patch as far as 9.0 so that the docs match the
code in each branch.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6121539aca2c797b8a9a78bb642ed060a9209d8e

Modified Files
--------------
doc/src/sgml/spi.sgml           |   47 +++++++++++++++++++++++++-------------
src/backend/executor/execMain.c |    6 +++-
2 files changed, 35 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Use correct output device for Windows prompts.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix SPI documentation for new handling of ExecutorRun's count pa