pgsql: Add defenses against integer overflow in dynahash numbuckets cal - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add defenses against integer overflow in dynahash numbuckets cal
Date
Msg-id E1Tici9-0008LK-KJ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add defenses against integer overflow in dynahash numbuckets calculations.

The dynahash code requires the number of buckets in a hash table to fit
in an int; but since we calculate the desired hash table size dynamically,
there are various scenarios where we might calculate too large a value.
The resulting overflow can lead to infinite loops, division-by-zero
crashes, etc.  I (tgl) had previously installed some defenses against that
in commit 299d1716525c659f0e02840e31fbe4dea3, but that covered only one
call path.  Moreover it worked by limiting the request size to work_mem,
but in a 64-bit machine it's possible to set work_mem high enough that the
problem appears anyway.  So let's fix the problem at the root by installing
limits in the dynahash.c functions themselves.

Trouble report and patch by Jeff Davis.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/691c5ebf79bb011648fad0e6b234b94a28177e3c

Modified Files
--------------
src/backend/executor/nodeHash.c   |    4 ++-
src/backend/utils/hash/dynahash.c |   49 ++++++++++++++++++++++++++++--------
2 files changed, 41 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add defenses against integer overflow in dynahash numbuckets cal
Next
From: Tom Lane
Date:
Subject: pgsql: Add defenses against integer overflow in dynahash numbuckets cal