pgsql: Avoid bogus "out-of-sequence timeline ID" errors in standby-mode - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Avoid bogus "out-of-sequence timeline ID" errors in standby-mode
Date
Msg-id E1TbZW5-0000pa-QA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid bogus "out-of-sequence timeline ID" errors in standby-mode.

When startup process opens a WAL segment after replaying part of it, it
validates the first page on the WAL segment, even though the page it's
really interested in later in the file. As part of the validation, it checks
that the TLI on the page header is >= the TLI it saw on the last page it
read. If the segment contains a timeline switch, and we have already
replayed it, and then re-open the WAL segment (because of streaming
replication got disconnected and reconnected, for example), the TLI check
will fail when the first page is validated. Fix that by relaxing the TLI
check when re-opening a WAL segment.

Backpatch to 9.0. Earlier versions had the same code, but before standby
mode was introduced in 9.0, recovery never tried to re-read a segment after
partially replaying it.

Reported by Amit Kapila, while testing a new feature.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/24c19e6bf96d556b3a9517ce42f54b5756ca0384

Modified Files
--------------
src/backend/access/transam/xlog.c |   33 ++++++++++++++++++++++++---------
1 files changed, 24 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Avoid bogus "out-of-sequence timeline ID" errors in standby-mode
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Avoid bogus "out-of-sequence timeline ID" errors in standby-mode