pgsql: Fix lo_import and lo_export to return useful error messages more - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix lo_import and lo_export to return useful error messages more
Date
Msg-id E1TLP0k-0000iU-As@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix lo_import and lo_export to return useful error messages more often.

I found that these functions tend to return -1 while leaving an empty error
message string in the PGconn, if they suffer some kind of I/O error on the
file.  The reason is that lo_close, which thinks it's executed a perfectly
fine SQL command, clears the errorMessage.  The minimum-change workaround
is to reorder operations here so that we don't fill the errorMessage until
after lo_close.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/bb3aa7a484a53d80784c367e2ff272b8730e338d

Modified Files
--------------
src/interfaces/libpq/fe-lobj.c |   33 ++++++++++++++++++++++++---------
1 files changed, 24 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix lo_import and lo_export to return useful error messages more
Next
From: Tom Lane
Date:
Subject: pgsql: Fix lo_import and lo_export to return useful error messages more