pgsql: Make plperl safe against functions that are redefined while runn - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make plperl safe against functions that are redefined while runn
Date
Msg-id E1TArwZ-0008ST-RU@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make plperl safe against functions that are redefined while running.

validate_plperl_function() supposed that it could free an old
plperl_proc_desc struct immediately upon detecting that it was stale.
However, if a plperl function is called recursively, this could result
in deleting the struct out from under an outer invocation, leading to
misbehavior or crashes.  Add a simple reference-count mechanism to
ensure that such structs are freed only when the last reference goes
away.

Per investigation of bug #7516 from Marko Tiikkaja.  I am not certain
that this error explains his report, because he says he didn't have
any recursive calls --- but it's hard to see how else it could have
crashed right there.  In any case, this definitely fixes some problems
in the area.

Back-patch to all active branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/59f23fe8d4eb0b95f029eaffdbcadc59d51f45cc

Modified Files
--------------
src/pl/plperl/expected/plperl.out |   18 ++++++
src/pl/plperl/plperl.c            |  104 +++++++++++++++++++++++++------------
src/pl/plperl/sql/plperl.sql      |   10 ++++
3 files changed, 99 insertions(+), 33 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Use .NOTPARALLEL in ecpg/Makefile to avoid a gmake parallelism b
Next
From: Tom Lane
Date:
Subject: pgsql: Make plperl safe against functions that are redefined while runn