pgsql: Fix line end mishandling in pg_upgrade on Windows. - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Fix line end mishandling in pg_upgrade on Windows.
Date
Msg-id E1T9NV7-0000dq-WD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f7b13e48375a5a8ea2a8b157622a9310512f4e27

Modified Files
--------------
contrib/pg_upgrade/dump.c |   13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Fix line end mishandling in pg_upgrade on Windows.
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Fix pg_upgrade test script's line end handling on Windows.