pgsql: Fix line end mishandling in pg_upgrade on Windows. - Mailing list pgsql-committers

Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/26f4fc01849b23d0541722d7cfdbd08739f81e1c

Modified Files
--------------
contrib/pg_upgrade/dump.c |   13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)