pgsql: Fix line end mishandling in pg_upgrade on Windows. - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Fix line end mishandling in pg_upgrade on Windows.
Date
Msg-id E1T9NUW-0000cT-Qb@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ea0b414a0d9caaad1b7f39acd57708895c4dd0f3

Modified Files
--------------
contrib/pg_upgrade/dump.c |   12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Restore SIGFPE handler after initializing PL/Perl.
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Fix line end mishandling in pg_upgrade on Windows.