pgsql: Replace memcpy() calls in xlog.c critical sections with struct a - Mailing list pgsql-committers

Replace memcpy() calls in xlog.c critical sections with struct assignments.

This gets rid of a dangerous-looking use of the not-volatile XLogCtl
pointer in a couple of spinlock-protected sections, where the normal
coding rule is that you should only access shared memory through a
pointer-to-volatile.  I think the risk is only hypothetical not actual,
since for there to be a bug the compiler would have to move the spinlock
acquire or release across the memcpy() call, which one sincerely hopes
it will not.  Still, it looks cleaner this way.

Per comment from Daniel Farina and subsequent discussion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2a2352e07df9ccc70689061b6453e226a56e7c79

Modified Files
--------------
src/backend/access/transam/xlog.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)