pgsql: Improve EXPLAIN's ability to cope with LATERAL references in pla - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve EXPLAIN's ability to cope with LATERAL references in pla
Date
Msg-id E1T783G-00058H-D7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve EXPLAIN's ability to cope with LATERAL references in plans.

push_child_plan/pop_child_plan didn't bother to adjust the "ancestors"
list of parent plan nodes when descending to a child plan node.  I think
this was okay when it was written, but it's not okay in the presence of
LATERAL references, since a subplan node could easily be returning a
LATERAL value back up to the same nestloop node that provides the value.
Per changed regression test results, the omission led to failure to
interpret Param nodes that have perfectly good interpretations.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d1a4db8d25ec53fd17e99168bc5efa0b16ef6fed

Modified Files
--------------
src/backend/utils/adt/ruleutils.c  |   18 ++++++++++--------
src/test/regress/expected/join.out |    2 +-
2 files changed, 11 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Comment fixes.
Next
From: Robert Haas
Date:
Subject: pgsql: Fix logic bug in gistchoose and gistRelocateBuildBuffersOnSplit.