pgsql: Improve reporting of error situations in find_other_exec(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve reporting of error situations in find_other_exec().
Date
Msg-id E1Suu0t-0004Ol-S6@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve reporting of error situations in find_other_exec().

This function suppressed any stderr output from the called program, which
is unnecessary in the normal case and unhelpful in error cases.  It also
gave a rather opaque message along the lines of "fgets failure: Success"
in case the called program failed to return anything on stdout.  Since
we've seen multiple reports of people not understanding what's wrong when
pg_ctl reports this, improve the message.

Back-patch to all active branches.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/022e8786da07d2859956d62b71297428a69f04f3

Modified Files
--------------
src/port/exec.c |   12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Update doc mention of diskchecker.pl to add URL for script; reta
Next
From: Tom Lane
Date:
Subject: pgsql: Improve reporting of error situations in find_other_exec().