pgsql: Fix walsender processes to establish a SIGALRM handler. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix walsender processes to establish a SIGALRM handler.
Date
Msg-id E1SpO9o-0001Op-FH@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix walsender processes to establish a SIGALRM handler.

Walsenders must have working SIGALRM handling during InitPostgres,
but they set the handler to SIG_IGN so that nothing would happen
if a timeout was reached.  This could result in two failure modes:

* If a walsender participated in a deadlock during its authentication
transaction, and was the last to wait in the deadly embrace, the deadlock
would not get cleared automatically.  This would require somebody to be
trying to take out AccessExclusiveLock on multiple system catalogs, so
it's not very probable.

* If a client failed to respond to a walsender's authentication challenge,
the intended disconnect after AuthenticationTimeout wouldn't happen, and
the walsender would wait indefinitely for the client.

For the moment, fix in back branches only, since this is fixed in a
different way in the timeout-infrastructure patch that's awaiting
application to HEAD.  If we choose not to apply that, then we'll need
to do this in HEAD as well.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2f9907cb83a12ac432fb81c87cfa735e1229a5bb

Modified Files
--------------
src/backend/replication/walsender.c |    3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: h-saito@pgfoundry.org (Hiroshi Saito)
Date:
Subject: psqlodbc - psqlodbc: follow of fixed.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix walsender processes to establish a SIGALRM handler.