pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding
Date
Msg-id E1SogOd-0002HI-6k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
plperl: Skip setting UTF8 flag when in SQL_ASCII encoding

When in SQL_ASCII encoding, strings passed around are not necessarily
UTF8-safe.  We had already fixed this in some places, but it looks like
we missed some.

I had to backpatch Peter Eisentraut's a8b92b60 to 9.1 in order for this
patch to cherry-pick more cleanly.

Patch from Alex Hunsaker, tweaked by Kyotaro HORIGUCHI and myself.

Some desultory cleanup and comment addition by me, during patch review.

Per bug report from Christoph Berg in
20120209102116.GA14429@msgid.df7cb.de

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7c460f0ba745611f4dadf413daa4ed9059951f92

Modified Files
--------------
src/pl/plperl/GNUmakefile              |    2 +-
src/pl/plperl/Util.xs                  |   27 ++++++++++----
src/pl/plperl/expected/plperl.out      |   10 -----
src/pl/plperl/expected/plperl_lc.out   |   33 +++++++++++++++++
src/pl/plperl/expected/plperl_lc_1.out |   41 +++++++++++++++++++++
src/pl/plperl/plperl_helpers.h         |   61 +++++++++++++++++++++++--------
src/pl/plperl/sql/plperl.sql           |    9 -----
src/pl/plperl/sql/plperl_lc.sql        |   24 ++++++++++++
8 files changed, 163 insertions(+), 44 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: plperl: Skip setting UTF8 flag when in SQL_ASCII encoding
Next
From: Alvaro Herrera
Date:
Subject: pgsql: PL/Perl: Avoid compiler warning from clang