pgsql: Fix mapping of PostgreSQL encodings to Python encodings. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix mapping of PostgreSQL encodings to Python encodings.
Date
Msg-id E1Smro2-0006gU-Ld@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix mapping of PostgreSQL encodings to Python encodings.

Windows encodings, "win1252" and so forth, are named differently in Python,
like "cp1252". Also, if the PyUnicode_AsEncodedString() function call fails
for some reason, use a plain ereport(), not a PLy_elog(), to report that
error. That avoids recursion and crash, if PLy_elog() tries to call
PLyUnicode_Bytes() again.

This fixes bug reported by Asif Naeem. Backpatch down to 9.0, before that
plpython didn't even try these conversions.

Jan Urbański, with minor comment improvements by me.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/773288016d00bd72e8e2bcb5b1eec67abb2d9e00

Modified Files
--------------
src/pl/plpython/plpy_util.c |   69 ++++++++++++++++++++++++++++++++++++++----
1 files changed, 62 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix mapping of PostgreSQL encodings to Python encodings.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix mapping of PostgreSQL encodings to Python encodings.