pgsql: Suppress compiler warnings in readfuncs.c. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Suppress compiler warnings in readfuncs.c.
Date
Msg-id E1Sl9th-0008G8-DL@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Suppress compiler warnings in readfuncs.c.

Commit 7357558fc8866e3a449aa9473c419b593d67b5b6 introduced "(void) token;"
into the READ_TEMP_LOCALS() macro, to suppress complaints from gcc 4.6
when the value of token was not used anywhere in a particular node-read
function.  However, this just moved the warning around: inspection of
buildfarm results shows that some compilers are now complaining that token
is being read before it's set.  Revert the READ_TEMP_LOCALS() macro change
and instead put "(void) token;" into READ_NODE_FIELD(), which is the
principal culprit for cases where the warning might occur.  In principle we
might need the same in READ_BITMAPSET_FIELD() and/or READ_LOCATION_FIELD(),
but it seems unlikely that a node would consist only of such fields, so
I'll leave them alone for now.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/39bfc94c86f1990e9db8ea3da0e82995cc1b76db

Modified Files
--------------
src/backend/nodes/readfuncs.c |    4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Prevent CREATE TABLE LIKE/INHERITS from (mis) copying whole-row
Next
From: Tom Lane
Date:
Subject: pgsql: Fix race condition in enum value comparisons.