pgsql: Fix some more bugs in contrib/xml2's xslt_process(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix some more bugs in contrib/xml2's xslt_process().
Date
Msg-id E1SbhPG-0005C5-Lt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix some more bugs in contrib/xml2's xslt_process().

It failed to check for error return from xsltApplyStylesheet(), as reported
by Peter Gagarinov.  (So far as I can tell, libxslt provides no convenient
way to get a useful error message in failure cases.  There might be some
inconvenient way, but considering that this code is deprecated it's hard to
get enthusiastic about putting lots of work into it.  So I just made it say
"failed to apply stylesheet", in line with the existing error checks.)

While looking at the code I also noticed that the string returned by
xsltSaveResultToString was never freed, resulting in a session-lifespan
memory leak.

Back-patch to all supported versions.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d9b31e4859df5325b7d3d2cc94b0e907f1cf1d3e

Modified Files
--------------
contrib/xml2/xslt_proc.c |   14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix some more bugs in contrib/xml2's xslt_process().
Next
From: Tom Lane
Date:
Subject: pgsql: Fix some more bugs in contrib/xml2's xslt_process().