pgsql: Force PL and range-type support functions to be owned by a super - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Force PL and range-type support functions to be owned by a super
Date
Msg-id E1SZwMs-00044Q-0o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Force PL and range-type support functions to be owned by a superuser.

We allow non-superusers to create procedural languages (with restrictions)
and range datatypes.  Previously, the automatically-created support
functions for these objects ended up owned by the creating user.  This
represents a rather considerable security hazard, because the owning user
might be able to alter a support function's definition in such a way as to
crash the server, inject trojan-horse SQL code, or even execute arbitrary
C code directly.  It appears that right now the only actually exploitable
problem is the infinite-recursion bug fixed in the previous patch for
CVE-2012-2655.  However, it's not hard to imagine that future additions of
more ALTER FUNCTION capability might unintentionally open up new hazards.
To forestall future problems, cause these support functions to be owned by
the bootstrap superuser, not the user creating the parent object.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ad0009e7be27489f5acc0a36217d9ea8f3db2b14

Modified Files
--------------
src/backend/catalog/pg_aggregate.c  |    1 +
src/backend/catalog/pg_proc.c       |    2 +-
src/backend/commands/functioncmds.c |    1 +
src/backend/commands/proclang.c     |    4 ++++
src/backend/commands/typecmds.c     |    2 ++
src/include/catalog/pg_proc_fn.h    |    1 +
6 files changed, 10 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Ignore SECURITY DEFINER and SET attributes for a PL's call handl
Next
From: Tom Lane
Date:
Subject: pgsql: Update time zone data files to tzdata release 2012c.