pgsql: Fix misleading output from gin_desc(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix misleading output from gin_desc().
Date
Msg-id E1SGHN1-0008TP-LT@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix misleading output from gin_desc().

XLOG_GIN_UPDATE_META_PAGE and XLOG_GIN_DELETE_LISTPAGE records were printed
with a list link field labeled as "blkno", which was confusing, especially
when the link was empty (InvalidBlockNumber).  Print the metapage block
number instead, since that's what's actually being updated.  We could
include the link values too as a separate field, but not clear it's worth
the trouble.

Back-patch to 8.4 where the dubious code was added.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e2923d341994a0aa3881ca29f345c40a98b6cb60

Modified Files
--------------
src/backend/access/gin/ginxlog.c |    8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix broken comparetup_datum code.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix misleading output from gin_desc().