pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo
Date
Msg-id E1SA87q-0002Si-0t@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve the -l (limit) option recently added to contrib/vacuumlo.

Instead of just stopping after removing an arbitrary subset of orphaned
large objects, commit and start a new transaction after each -l objects.
This is just as effective as the original patch at limiting the number of
locks used, and it doesn't require doing the OID collection process
repeatedly to get everything.  Since the option no longer changes the
fundamental behavior of vacuumlo, and it avoids a known server-side
limitation, enable it by default (with a default limit of 1000 LOs per
transaction).

In passing, be more careful about properly quoting the names of tables
and fields, and do some other cosmetic cleanup.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/64c604898e812aa93c124c666e8709fff1b8dd26

Modified Files
--------------
contrib/vacuumlo/vacuumlo.c |  131 +++++++++++++++++++++++++++++++------------
doc/src/sgml/vacuumlo.sgml  |   26 +++++----
2 files changed, 109 insertions(+), 48 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: pg_dump: get rid of die_horribly
Next
From: Robert Haas
Date:
Subject: pgsql: Add some CHECK_FOR_INTERRUPTS() calls to the heap-sort call path