BUG #6343: PGTYPES library missing qualifiers - Mailing list pgsql-bugs

From kojiro@hello-channel.com
Subject BUG #6343: PGTYPES library missing qualifiers
Date
Msg-id E1RbZmg-0007KG-4v@wrigleys.postgresql.org
Whole thread Raw
Responses Re: BUG #6343: PGTYPES library missing qualifiers
List pgsql-bugs
The following bug has been logged on the website:

Bug reference:      6343
Logged by:          Daniel Loffgren
Email address:      kojiro@hello-channel.com
PostgreSQL version: 9.1.1
Operating system:   NetBSD
Description:=20=20=20=20=20=20=20=20

In the ecpg PGTYPES library, there are functions like this:=20

extern int PGTYPEStimestamp_fmt_asc(timestamp *, char *, int, char *);

The last argument is the formatting string, yet isn't constant. This
generates warnings/errors on many compilers that are watching for discarding
of qualifiers when passing in string literals. It's a simple fix, although I
noticed that in PGTYPEStimestamp_defmt_asc the code is altering the
formatter if it is null, which prevents making the formatter const. However,
dttofmtasc_replace does not alter the formatter, and so should not pose a
problem for PGTYPEStimestamp_fmt_asc which passes straight to it.

pgsql-bugs by date:

Previous
From: Noah Misch
Date:
Subject: fatal flex error in guc-file.l kills the postmaster
Next
From: Craig Ringer
Date:
Subject: Re: R: BUG #6342: libpq blocks forever in "poll" function