pgsql: Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records.
Date
Msg-id E1RU10F-0000hV-1r@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records.

A simple thinko in ginRedoUpdateMetapage, namely failing to increment a
loop counter, led to inserting records into the last pending-list page in
the wrong order (the opposite of that intended).  So far as I can tell,
this would not upset the code that eventually flushes pending items into
the main part of the GIN index.  But it did break the code that searched
the pending list for matches, resulting in transient failure to find
matching entries during index lookups, as illustrated in bug #6307 from
Maksym Boguk.

Back-patch to 8.4 where the incorrect code was introduced.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/eacff260fd220e82ca13cab2ad61d3aeb6eed445

Modified Files
--------------
src/backend/access/gin/ginxlog.c |    2 ++
1 files changed, 2 insertions(+), 0 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix erroneous replay of GIN_UPDATE_META_PAGE WAL records.